improve footer version logic #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add v prefix if the API does not return the v prefix
zhx828
approved these changes
Dec 19, 2019
alisman
reviewed
Dec 19, 2019
| @@ -79,7 +79,11 @@ export class AppStore { | |||
| invoke:async()=>{ | |||
| const portalVersionResult = await internalClient.getInfoUsingGET({}); | |||
| if (portalVersionResult && portalVersionResult.portalVersion) { | |||
| return Promise.resolve("v" + portalVersionResult.portalVersion.split('-')[0]); | |||
| let version = portalVersionResult.portalVersion.split('-')[0]; | |||
| if (!version.startsWith("v")) { | |||
There was a problem hiding this comment.
startsWith is probably not supported in IE. I'll test it.
There was a problem hiding this comment.
nevermind it works and we use this elsewhere
alisman
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add v prefix if the API does not return the v prefix
Avoids getting things like
vv3.1.8in the footer